Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checking commit signature when signed with ssh key #29

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

gavin-ts
Copy link
Contributor

Summary

Fixes checking if a commit is signed to work when it is signed with an ssh key.

Details

  • If a commit is signed with an ssh key, git needs the gpg.ssh.allowedSignersFile to be configured otherwise it will output an error message.
  • this configures it with an empty file to successfully output the commit signature status
  • the CI step is to check if a commit is signed at all (status != N (not signed)), not to verify the signature (github will do that), so we just need an empty file and the ssh-signed commit's status will be U (unknown validity)

@gavin-ts gavin-ts changed the title setup empty allowed signers to check ssh signature status fix checking commit signature when signed with ssh key Oct 12, 2023
@gavin-ts gavin-ts merged commit 8a1fb2d into master Oct 12, 2023
6 checks passed
@gavin-ts gavin-ts deleted the fix-signature-check-with-ssh branch October 12, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants